Skip to content

8341893: AArch64: Micro-optimize compressed ptr decoding #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dchuyko
Copy link
Member

@dchuyko dchuyko commented Mar 28, 2025

This is a small clean backport to fix compressed ptr decoding inefficiency.

Testing: tier 1,2 on linux-aarch64.


Progress

  • JDK-8341893 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341893: AArch64: Micro-optimize compressed ptr decoding (Enhancement - P4 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1551/head:pull/1551
$ git checkout pull/1551

Update a local copy of the PR:
$ git checkout pull/1551
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1551

View PR using the GUI difftool:
$ git pr show -t 1551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1551.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e3f650393744790e24820b2d6d99dd1da1a44de6 8341893: AArch64: Micro-optimize compressed ptr decoding Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

⚠️ @dchuyko This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@dchuyko
Copy link
Member Author

dchuyko commented Mar 28, 2025

/approval request The change is tiny, and 21u backport is clean. The operation is small but frequent, so it's good to generate smaller/faster code by the aarch64 macro assembler.

Testing: tier 1,2,3 on linux-aarch64.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@dchuyko
8341893: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Mar 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 25, 2025

@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 23, 2025

@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant