8312475: org.jline.util.PumpReader signed byte problem

[Baraa-Hasheesh]

Clean Backport JDK-8312475: SonarCloud reports a possible issue in read method

• buffer.get() reads a signed byte so it has a range of -128-127
• When end of file is reached the read method returns -1 signed integer

When the buffer.get() reads -1 => it returns 0xFF as a signed byte value, this causes the SonarCloud to confuse the possibility that the -1 byte value (0xFF), equals the -1 EOF value (0xFFFFFFFF)

This simply added a casting to & 0xFF to avoid this confusion.

---

Progress

• JDK-8312475 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312475: org.jline.util.PumpReader signed byte problem (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1552/head:pull/1552
$ git checkout pull/1552

Update a local copy of the PR:
$ git checkout pull/1552
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1552

View PR using the GUI difftool:
$ git pr show -t 1552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1552.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @Baraa-Hasheesh, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Baraa-Hasheesh" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@Baraa-Hasheesh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312475: org.jline.util.PumpReader signed byte problem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• 28cb19e: 8136895: Writer not closed with disk full error, file resource leaked
• 2439c6d: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• bc441e3: 8353709: Debug symbols bundle should contain full debug files when building --with-external-symbols-in-bundles=public
• ... and 80 more: https://git.openjdk.org/jdk21u-dev/compare/5eb51cdc5cb1b9b901e51485b3fafcb69bd75e60...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[Baraa-Hasheesh]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[shipilev]

Let's ping @robilad to see what is going on with OCA verification :)

[openjdk]

⚠️ @Baraa-Hasheesh This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (b3de99b0)

[Baraa-Hasheesh]

/approval request Fixes a false reporting issue in SonarCloud due to confusion between -1(Byte) & -1(int) values. Applies cleanly. tier{1,2,3} tests passes. Risk is minimal as no real change in code behaviour was made.

[openjdk]

@Baraa-Hasheesh
8312475: The approval request has been created successfully.

[Baraa-Hasheesh]

/integrate

[openjdk]

@Baraa-Hasheesh
Your change (at version b3de99b) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 9c5807b.
Since your change was applied there have been 84 commits pushed to the master branch:

• fe1a91c: 8322475: Extend printing for System.map
• 28cb19e: 8136895: Writer not closed with disk full error, file resource leaked
• 2439c6d: 8349637: Integer.numberOfLeadingZeros outputs incorrectly in certain cases
• ... and 81 more: https://git.openjdk.org/jdk21u-dev/compare/5eb51cdc5cb1b9b901e51485b3fafcb69bd75e60...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @Baraa-Hasheesh Pushed as commit 9c5807b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.