-
Notifications
You must be signed in to change notification settings - Fork 126
8352716: (tz) Update Timezone Data to 2025b #1557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 46 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of 2025b tzdata. Nearly clean, but needed to re-add Risk: Medium to Low. Tier 1 and relevant tz tests passing, as well as GHA sanity check tests. Backporting tzdata changes is a common enough procedure that, after review, we can be reasonably confident will work as intended. Testing:
|
Hi @satyenme |
I'm seeing this request for 24: openjdk/jdk24u#161. To avoid duplication, I'll wait for further action there |
Yes, I'm already handling the 24u update. I'm not sure of the rush here. I was planning to handle further backports as each was integrated. Attempting to do them in parallel risks extra work if changes come up in review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches my patch for 24u (openjdk/jdk24u#161) and testing looks good. I'll look over the ones for 8u, 11u & 17u tomorrow.
Hi @satyenme, @gnu-andrew |
I just pushed 24u so this should be good for approval now. I'd appreciate a bit of time today to review 8u, 11u & 17u before those go in though. |
/integrate Edit: missed that the label was removed. |
@satyenme This pull request has not yet been marked as ready for integration. |
/integrate |
/sponsor |
Going to push as commit 27f3ab6.
Your commit was automatically rebased without conflicts. |
@phohensee @satyenme Pushed as commit 27f3ab6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of tzdata2025b. Nearly clean, but contains
zone.tab
file, which was removed by JDK-8166983.Reverted change to
test/jdk/java/util/TimeZone/TimeZoneData/aliases.txt
and.../displaynames.txt
when runningmake
intest/jdk/java/util/TimeZone/tools/share
to avoid thejava/util/TimeZone/Bug6329116.java
test failing, just as was done previously for 2024b.Passed tier1 tests and
make run-test TEST="jdk/java/util/TimeZone jdk/java/time/test jdk/sun/util/resources jdk/sun/text/resources jdk/sun/util/calendar"
locally, GHA sanity tests.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1557/head:pull/1557
$ git checkout pull/1557
Update a local copy of the PR:
$ git checkout pull/1557
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1557/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1557
View PR using the GUI difftool:
$ git pr show -t 1557
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1557.diff
Using Webrev
Link to Webrev Comment