Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8323210: Update the usage of cmsFLAGS_COPY_ALPHA #156

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 9, 2024

Hi all,

This pull request contains a backport of commit openjdk/jdk@aba1933 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 9 Jan 2024 and was reviewed by Philip Race.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8323210 needs maintainer approval

Issue

  • JDK-8323210: Update the usage of cmsFLAGS_COPY_ALPHA (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/156.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aba19334eaeb46d37169cddeef929b13e050a60e 8323210: Update the usage of cmsFLAGS_COPY_ALPHA Jan 9, 2024
@openjdk
Copy link

openjdk bot commented Jan 9, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review January 10, 2024 01:04
@openjdk
Copy link

openjdk bot commented Jan 10, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2024

Webrevs

@openjdk openjdk bot added approval and removed approval labels Jan 15, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the approval label Feb 29, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323210: Update the usage of cmsFLAGS_COPY_ALPHA

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 183 new commits pushed to the master branch:

  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • dc8759c: 8316053: Open some swing tests 3
  • ef13a82: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
  • 64b70be: 8326773: Bump update version for OpenJDK: jdk-21.0.4
  • ... and 173 more: https://git.openjdk.org/jdk21u-dev/compare/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 1, 2024
@mrserb
Copy link
Member Author

mrserb commented Mar 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 2, 2024

Going to push as commit ee6445c.
Since your change was applied there have been 185 commits pushed to the master branch:

  • 94634c0: 8313394: Array Elements in OldObjectSample event has the incorrect description
  • 4243aed: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • dc8759c: 8316053: Open some swing tests 3
  • ... and 175 more: https://git.openjdk.org/jdk21u-dev/compare/d5b8c283ba6d58eb4c3af9709c7c3ad60dc11366...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 2, 2024
@openjdk openjdk bot closed this Mar 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2024
@openjdk
Copy link

openjdk bot commented Mar 2, 2024

@mrserb Pushed as commit ee6445c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the backport-mrserb-aba19334 branch March 2, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant