8319372: C2 compilation fails with "Bad immediate dominator info"

[shipilev]

Clean backport to fix C2 bug and better parity.

Testing:

• New regression tests fail with the fix and pass with it
• Linux x86_64 server fastdebug, tier{1,2,3,4}
• Linux x86_64 server fastdebug, tier{1,2,3,4}

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8319372 needs maintainer approval

Issue

• JDK-8319372: C2 compilation fails with "Bad immediate dominator info" (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/157.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (eab69cd3)

[shipilev]

/approval request Clean backport to fix C2 bug and better parity.

[openjdk]

@shipilev
8319372: The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319372: C2 compilation fails with "Bad immediate dominator info"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 0ac1bb7: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
• 9b5cd9d: 8315594: Open source few headless Swing misc tests
• f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
• 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
• 45df078: 8319124: Update XML Security for Java to 3.0.3
• 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
• b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
• 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
• 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
• ... and 15 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit b4c163d.
Since your change was applied there have been 25 commits pushed to the master branch:

• 0ac1bb7: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
• 9b5cd9d: 8315594: Open source few headless Swing misc tests
• f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
• 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
• 45df078: 8319124: Update XML Security for Java to 3.0.3
• 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
• b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
• 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
• 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
• ... and 15 more: https://git.openjdk.org/jdk21u-dev/compare/d44b5dc7a634b08f27f9a3e71112607a12023f8b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit b4c163d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.