Skip to content

8341378: Open source few TrayIcon tests - Set8 #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 2, 2025

I backport this for parity with 21.0.8-oracle


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341378 needs maintainer approval

Issue

  • JDK-8341378: Open source few TrayIcon tests - Set8 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1581/head:pull/1581
$ git checkout pull/1581

Update a local copy of the PR:
$ git checkout pull/1581
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1581/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1581

View PR using the GUI difftool:
$ git pr show -t 1581

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1581.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 2, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341378: Open source few TrayIcon tests - Set8

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport b9db74a64577bf2b79570a789c91de6549a50788 8341378: Open source few TrayIcon tests - Set8 Apr 2, 2025
@openjdk
Copy link

openjdk bot commented Apr 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 2, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 2, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 2, 2025

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 5, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 7, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 7, 2025

Going to push as commit 2510358.
Since your change was applied there have been 23 commits pushed to the master branch:

  • ec7d359: 8340967: Open source few Cursor tests - Set2
  • 4a8f027: 8340555: Open source DnD tests - Set4
  • dc59215: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small
  • 2d49408: 8340271: Open source several AWT Robot tests
  • ddf0d07: 8321931: memory_swap_current_in_bytes reports 0 as "unlimited"
  • 1c713bb: 8315871: Opensource five more Swing regression tests
  • 4221c66: 8346888: [ubsan] block.cpp:1617:30: runtime error: 9.97582e+36 is outside the range of representable values of type 'int'
  • c983402: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
  • 237a45b: 8340625: Open source additional Component tests (part 3)
  • c1a78d2: 8341239: Open source closed frame tests # 3
  • ... and 13 more: https://git.openjdk.org/jdk21u-dev/compare/32cad6923ecbb47e7321f992d830020c69acd649...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 7, 2025
@openjdk openjdk bot closed this Apr 7, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 7, 2025
@openjdk
Copy link

openjdk bot commented Apr 7, 2025

@GoeLin Pushed as commit 2510358.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8341378 branch April 7, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant