8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams

[phohensee]

Backport for parity with Oracle 21.0.8. Passes tier2 and modified tests. Low risk: the patch /1 locks existing unlocked code, which is at worst a performance issue, but necessary for correctness, /2 checks for a closed stream before pushing a data frame into it, see pushDataFrame() in Stream.java.

Clean except for whitespace change in Stream.java from 8309118, 8309118 isn't in 21u.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8343855 needs maintainer approval

Issue

• JDK-8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams (Bug - P3 - Approved)

Reviewers

• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1585/head:pull/1585
$ git checkout pull/1585

Update a local copy of the PR:
$ git checkout pull/1585
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1585/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1585

View PR using the GUI difftool:
$ git pr show -t 1585

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1585.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams

Reviewed-by: rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 67c4a08: 8340024: In ClassReader, extract a constant for the superclass supertype_index
• 4daaffc: 8337795: Type annotation attached to incorrect type during class reading

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 04: Full - Incremental (eaffe28d)
• 03: Full - Incremental (f4e41e17)
• 02: Full - Incremental (33149d78)
• 01: Full - Incremental (c6efee77)
• 00: Full (d0d964d2)

[openjdk]

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

/approval request Backport for parity with Oracle 21.0.8. Passes tier2 and modified tests. Low risk: the patch /1 locks existing unlocked code, which is at worst a performance issue, but necessary for correctness, /2 checks for a closed stream before pushing a data frame into it, see pushDataFrame() in Stream.java.

Clean except for whitespace change in Stream.java from 8309118, 8309118 isn't in 21u.

[openjdk]

@phohensee
8343855: The approval request has been created successfully.

[GoeLin]

Hi @phohensee,
Thanks for the detailed risk assessment, I think this is ok for backport.
One question: Why is there a change to test ShutdownNow.java in this change? I can't see that in the original.

[RealCLanger]

Hi @phohensee, Thanks for the detailed risk assessment, I think this is ok for backport. One question: Why is there a change to test ShutdownNow.java in this change? I can't see that in the original.

This is weird. It seems it contains the changes of the already committed backport df5e51f. Maybe you should merge in master to this PR once more?

[GoeLin]

Hi @phohensee,
I think this was accidentially committed by "Revert part of 8309118"

[phohensee]

Merged with master and seems fine now.

[GoeLin]

Thanks for fixing this! GHA failure looks unrelated.

[phohensee]

/integrate

[openjdk]

Going to push as commit 5675b62.
Since your change was applied there have been 2 commits pushed to the master branch:

• 67c4a08: 8340024: In ClassReader, extract a constant for the superclass supertype_index
• 4daaffc: 8337795: Type annotation attached to incorrect type during class reading

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit 5675b62.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.