8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

[phohensee]

Backport for parity with Oracle 21.0.8. Clean, low risk: test only, modified test passes.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8347995 needs maintainer approval

Issue

• JDK-8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1596/head:pull/1596
$ git checkout pull/1596

Update a local copy of the PR:
$ git checkout pull/1596
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1596/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1596

View PR using the GUI difftool:
$ git pr show -t 1596

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1596.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

/approval request Backport for parity with Oracle 21.0.8. Clean, low risk: test only, modified test passes.

[openjdk]

@phohensee
8347995: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (8e7f6f31)

[phohensee]

/integrate

[openjdk]

Going to push as commit d2be3b7.
Since your change was applied there have been 15 commits pushed to the master branch:

• 4b5ca21: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
• e8daf0c: 8344361: Restore null return for invalid services from legacy providers
• ff0aa06: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 7c45ed3: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
• 5f5e6e5: 8345357: test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java fails in ubuntu22.04
• 41fe4e2: 8340978: Open source few DnD tests - Set6
• 2510358: 8341378: Open source few TrayIcon tests - Set8
• ec7d359: 8340967: Open source few Cursor tests - Set2
• 4a8f027: 8340555: Open source DnD tests - Set4
• dc59215: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small
• ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/237a45b1bad840506e02d2b52f5d276554e490c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit d2be3b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.