Skip to content

Conversation

@phohensee
Copy link
Member

@phohensee phohensee commented Apr 4, 2025

Backport for parity with Oracle 21.0.8. Clean, low risk: obvious bug, updated and new test pass, Provider tests pass: test/jdk/java/security/Provider and test/jdk/sun/security/pkcs11/Provider.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344361 needs maintainer approval

Issue

  • JDK-8344361: Restore null return for invalid services from legacy providers (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1597/head:pull/1597
$ git checkout pull/1597

Update a local copy of the PR:
$ git checkout pull/1597
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1597/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1597

View PR using the GUI difftool:
$ git pr show -t 1597

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1597.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e20bd018c4046870d0cf632bb8e5440cb9f5c3c2 8344361: Restore null return for invalid services from legacy providers Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@phohensee phohensee closed this Apr 4, 2025
@phohensee phohensee deleted the 8344361 branch April 4, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant