Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8310807: java/nio/channels/DatagramChannel/Connect.java timed out #16

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 13, 2023

Clean backport to improve tests and parity with 21.0.3-oracle.

Additional testing:

  • Affected test still passes

Progress

  • JDK-8310807 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310807: java/nio/channels/DatagramChannel/Connect.java timed out (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/16.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

/approval request Clean backport to improve tests and parity with 21.0.3-oracle. Applies cleanly. Test passes.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 570dffb104fc37f053fcdf38a24aa2cabdc921c0 8310807: java/nio/channels/DatagramChannel/Connect.java timed out Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

@shipilev
8310807: The approval request has been updated successfully.

@mlbridge
Copy link

mlbridge bot commented Dec 13, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Dec 13, 2023

Accidental duplicate of #15.

@shipilev shipilev closed this Dec 13, 2023
@shipilev shipilev deleted the JDK-8312428-test-pkcs11 branch February 7, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
1 participant