8318613: ChoiceFormat patterns are not well tested

[SoniaZaldana]

Hi all,

This pull request contains a backport of commit 10427c02 from the openjdk/jdk repository.

The commit being backported was authored by Justin Lu on 25 Oct 2023 and was reviewed by Naoto Sato.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318613 needs maintainer approval

Issue

• JDK-8318613: ChoiceFormat patterns are not well tested (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/164/head:pull/164
$ git checkout pull/164

Update a local copy of the PR:
$ git checkout pull/164
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 164

View PR using the GUI difftool:
$ git pr show -t 164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/164.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (04b00517)

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318613: ChoiceFormat patterns are not well tested

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 0ac1bb7: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
• 9b5cd9d: 8315594: Open source few headless Swing misc tests
• f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
• 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
• 45df078: 8319124: Update XML Security for Java to 3.0.3
• 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
• b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
• 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
• 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
• ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/cd166703a20c4ac51bc6478e8a0bb1275d9cb913...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SoniaZaldana]

/integrate

[openjdk]

@SoniaZaldana
Your change (at version 04b0051) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 32a4568.
Since your change was applied there have been 61 commits pushed to the master branch:

• 1e8c226: 8316106: Open source few swing JInternalFrame and JMenuBar tests
• 8d536b6: 8318154: Improve stability of WheelModifier.java test
• fcf9ebd: 8319103: Popups that request focus are not shown on Linux with Wayland
• 9ca8761: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
• 95142cf: Merge
• 375769c: Merge
• f423faa: 8322883: [BACKOUT] 8225377: type annotations are not visible to javac plugins across compilation boundaries
• 53118a3: Merge
• e831175: 8317547: Enhance TLS connection support
• 03c3ae1: Merge
• ... and 51 more: https://git.openjdk.org/jdk21u-dev/compare/cd166703a20c4ac51bc6478e8a0bb1275d9cb913...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @SoniaZaldana Pushed as commit 32a4568.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.