8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java

[SoniaZaldana]

Hi all,

This pull request contains a backport of commit 9481d06e from the openjdk/jdk repository.

The commit being backported was authored by Renjith Kannath Pariyangad on 2 Jan 2024 and was reviewed by Alexey Ivanov.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8320343 needs maintainer approval

Issue

• JDK-8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/165.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (cddbfeb3)
• 00: Full (01f1c1df)

[SoniaZaldana]

I have verified the GHA failure is not related to this backport. I have a successful run in a personal branch (https://github.com/SoniaZaldana/jdk21u-dev/actions/runs/7890867343). Could reviewers please advise on how to re-run the GHA job on the bot branch?

[GoeLin]

Hi
to rerun the GHA either go to your branch (at the top right) openjdk-bots:backport-SoniaZaldana-9481d06e
and there click "Sync fork" and then "update branch".
Alternatively you can start them by going to the branch, select the Action tab, select the run, and click "Re-run all jobs."

[openjdk]

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
• dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
• 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[SoniaZaldana]

Hi @GoeLin, I don't seem to have write access for the bot fork so I'm unable to sync the fork or re-run any actions.

[shipilev]

It looks to me that compiler/intrinsics/TestLongUnsignedDivMod.java had failed on macos-x64. This deserves a separate follow-up, but I don't think this is an integration blocker.

[GoeLin]

@SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this?

[SoniaZaldana]

/integrate

[SoniaZaldana]

@SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this?

No, I was just waiting to see if the Risk-V issue got resolved. I'll integrate.

[openjdk]

@SoniaZaldana
Your change (at version cddbfeb) is now ready to be sponsored by a Committer.

[shipilev]

There is no need to wait for RISC-V GHA to get green.

/sponsor

[openjdk]

Going to push as commit 2d62854.
Since your change was applied there have been 4 commits pushed to the master branch:

• fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
• dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
• 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
• ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @SoniaZaldana Pushed as commit 2d62854.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.