Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java #165

Closed

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Jan 12, 2024

Hi all,

This pull request contains a backport of commit 9481d06e from the openjdk/jdk repository.

The commit being backported was authored by Renjith Kannath Pariyangad on 2 Jan 2024 and was reviewed by Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320343 needs maintainer approval

Issue

  • JDK-8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/165.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9481d06e62334872af539ccfb8c1ea25e30a6da3 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java Jan 12, 2024
@openjdk
Copy link

openjdk bot commented Jan 12, 2024

This backport pull request has now been updated with issue from the original commit.

@SoniaZaldana SoniaZaldana marked this pull request as ready for review February 12, 2024 16:01
@openjdk
Copy link

openjdk bot commented Feb 12, 2024

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 12, 2024
@mlbridge
Copy link

mlbridge bot commented Feb 12, 2024

Webrevs

@openjdk openjdk bot added the approval label Feb 13, 2024
@SoniaZaldana
Copy link
Member Author

SoniaZaldana commented Feb 13, 2024

I have verified the GHA failure is not related to this backport. I have a successful run in a personal branch (https://github.com/SoniaZaldana/jdk21u-dev/actions/runs/7890867343). Could reviewers please advise on how to re-run the GHA job on the bot branch?

@GoeLin
Copy link
Member

GoeLin commented Feb 14, 2024

Hi
to rerun the GHA either go to your branch (at the top right) openjdk-bots:backport-SoniaZaldana-9481d06e
and there click "Sync fork" and then "update branch".
Alternatively you can start them by going to the branch, select the Action tab, select the run, and click "Re-run all jobs."

@openjdk
Copy link

openjdk bot commented Feb 14, 2024

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 14, 2024
@SoniaZaldana
Copy link
Member Author

Hi @GoeLin, I don't seem to have write access for the bot fork so I'm unable to sync the fork or re-run any actions.

@shipilev
Copy link
Member

It looks to me that compiler/intrinsics/TestLongUnsignedDivMod.java had failed on macos-x64. This deserves a separate follow-up, but I don't think this is an integration blocker.

@GoeLin
Copy link
Member

GoeLin commented Mar 4, 2024

@SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this?

@SoniaZaldana
Copy link
Member Author

/integrate

@SoniaZaldana
Copy link
Member Author

@SoniaZaldana, seems your re-run workde. We now only see the well known Risk-V issue. Is there anything else keeping you from integrating this?

No, I was just waiting to see if the Risk-V issue got resolved. I'll integrate.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@SoniaZaldana
Your change (at version cddbfeb) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Mar 4, 2024

There is no need to wait for RISC-V GHA to get green.

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 4, 2024

Going to push as commit 2d62854.
Since your change was applied there have been 4 commits pushed to the master branch:

  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2024
@openjdk openjdk bot closed this Mar 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2024
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Mar 4, 2024
@openjdk
Copy link

openjdk bot commented Mar 4, 2024

@shipilev @SoniaZaldana Pushed as commit 2d62854.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants