Skip to content

8340366: Open source several AWT Dialog tests - Batch 3 #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 15, 2025

I backport this for parity with 21.0.8-oracle.

Resolved ProblemList, probably clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340366 needs maintainer approval

Issue

  • JDK-8340366: Open source several AWT Dialog tests - Batch 3 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1657/head:pull/1657
$ git checkout pull/1657

Update a local copy of the PR:
$ git checkout pull/1657
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1657

View PR using the GUI difftool:
$ git pr show -t 1657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1657.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 15, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340366: Open source several AWT Dialog tests - Batch 3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e13da98: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool
  • d1249a7: 8353138: Screen capture for test TaskbarPositionTest.java, failure case

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a7d2077fe20d73f49a003c15469c2aa9bda1b30f 8340366: Open source several AWT Dialog tests - Batch 3 Apr 15, 2025
@openjdk
Copy link

openjdk bot commented Apr 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 15, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2025

Webrevs

@openjdk openjdk bot added the clean label Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 16, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 16, 2025

Going to push as commit 04c4241.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 16, 2025
@openjdk openjdk bot closed this Apr 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2025
@openjdk
Copy link

openjdk bot commented Apr 16, 2025

@GoeLin Pushed as commit 04c4241.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8340366 branch April 16, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant