Skip to content

8352512: TestVectorZeroCount: counter not reset between iterations #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Apr 17, 2025

Clean backport of JDK-8352512.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352512 needs maintainer approval

Issue

  • JDK-8352512: TestVectorZeroCount: counter not reset between iterations (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1672/head:pull/1672
$ git checkout pull/1672

Update a local copy of the PR:
$ git checkout pull/1672
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1672/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1672

View PR using the GUI difftool:
$ git pr show -t 1672

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1672.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352512: TestVectorZeroCount: counter not reset between iterations

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 67c4a08: 8340024: In ClassReader, extract a constant for the superclass supertype_index

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 1c0fa0af7847d80fd3fbe38f28207aab270609b3 8352512: TestVectorZeroCount: counter not reset between iterations Apr 17, 2025
@openjdk
Copy link

openjdk bot commented Apr 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

⚠️ @TheRealMDoerr This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 17, 2025
@TheRealMDoerr
Copy link
Contributor Author

/approval request Same as for jdk24u-fix-request.

@openjdk
Copy link

openjdk bot commented Apr 17, 2025

@TheRealMDoerr
8352512: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Apr 17, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Apr 18, 2025
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 19, 2025

Going to push as commit 181f952.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c40e6ef: 8337998: CompletionFailure in getEnclosingType attaching type annotations
  • 5675b62: 8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams
  • 67c4a08: 8340024: In ClassReader, extract a constant for the superclass supertype_index

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 19, 2025
@openjdk openjdk bot closed this Apr 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2025
@openjdk
Copy link

openjdk bot commented Apr 19, 2025

@TheRealMDoerr Pushed as commit 181f952.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant