8324517: C2: crash in compiled code because of dependency on removed range check CastIIs

[satyenme]

Backporting JDK-8324517: C2: crash in compiled code because of dependency on removed range check CastIIs. Fix adjusts code to retain range check CastII nodes after loop opts until the end of optimizations, removing them at the end of all optimizations to avoid performance regressions. Ran GHA Sanity Checks, local Tier 1 and 2, and new test/hotspot/jtreg/compiler/rangechecks/TestArrayAccessAboveRCAfterRCCastIIEliminated.java tests. Patch is clean.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8324517 needs maintainer approval

Issue

• JDK-8324517: C2: crash in compiled code because of dependency on removed range check CastIIs (Bug - P3 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1691/head:pull/1691
$ git checkout pull/1691

Update a local copy of the PR:
$ git checkout pull/1691
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1691

View PR using the GUI difftool:
$ git pr show -t 1691

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1691.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (db3f168c)

[satyenme]

/approval request for backport. Fix adjusts code to retain range check CastII nodes after loop opts until the end of optimizations, removing them at the end of all optimizations to avoid performance regressions.

Risk: Medium. Tip change was merged in May 2024, but adjusting compilation logic. Adds test to help mitigate risk.

Testing:

• GHA Sanity Checks
• Tier 1 and 2 tests locally

[openjdk]

@satyenme
8324517: The approval request has been created successfully.

[satyenme]

Missed that tip change was backed out and redone, closing