Skip to content

8347596: Update HSS/LMS public key encoding #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 24, 2025

I backport this for parity with 21.0.8-oracle.

Omitted the change to KeyUtil.java.
The code edited by the original change was added to KeyUtil by https://bugs.openjdk.org/browse/JDK-8302233 "HSS/LMS: keytool and jarsigner changes".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347596 needs maintainer approval

Issue

  • JDK-8347596: Update HSS/LMS public key encoding (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1704/head:pull/1704
$ git checkout pull/1704

Update a local copy of the PR:
$ git checkout pull/1704
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1704

View PR using the GUI difftool:
$ git pr show -t 1704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1704.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347596: Update HSS/LMS public key encoding

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0ee6ba9c4c998baeb733363d00db138864f49406 8347596: Update HSS/LMS public key encoding Apr 24, 2025
@openjdk
Copy link

openjdk bot commented Apr 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Apr 24, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 24, 2025

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 25, 2025

Thanks for the reviews!

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Apr 25, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Apr 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 28, 2025

Going to push as commit 35fdf15.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 28, 2025
@openjdk openjdk bot closed this Apr 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 28, 2025
@openjdk
Copy link

openjdk bot commented Apr 28, 2025

@GoeLin Pushed as commit 35fdf15.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8347596 branch April 28, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants