Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong #171

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 15, 2024

I backport this for parity with 21.0.3-oracle.


Progress

  • JDK-8317522 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/171/head:pull/171
$ git checkout pull/171

Update a local copy of the PR:
$ git checkout pull/171
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 171

View PR using the GUI difftool:
$ git pr show -t 171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/171.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4c5b66dceab15ce27f742c4173e14156249eb61a 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong Jan 15, 2024
@openjdk
Copy link

openjdk bot commented Jan 15, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 15, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 15, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 16, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 0ac1bb7: 8317804: com/sun/jdi/JdwpAllowTest.java fails on Alpine 3.17 / 3.18
  • 9b5cd9d: 8315594: Open source few headless Swing misc tests
  • f57f2cb: 8321164: javac with annotation processor throws AssertionError: Filling jrt:/... during JarFileObject[/...]
  • 551855c: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
  • 4b82978: 8318971: Better Error Handling for Jar Tool When Processing Non-existent Files
  • 45df078: 8319124: Update XML Security for Java to 3.0.3
  • 77c743e: 8320888: Shenandoah: Enable ShenandoahVerifyOptoBarriers in debug builds
  • b114a5e: 8320877: Shenandoah: Remove ShenandoahUnloadClassesFrequency support
  • 7fe7cfc: 8320907: Shenandoah: Remove ShenandoahSelfFixing flag
  • 1b5aeb9: 8323065: Unneccesary CodeBlob lookup in CompiledIC::internal_set_ic_destination
  • ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/e08eb0ec0181228468c51129a6a9378d749d6d02...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 17, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

Going to push as commit 0668efa.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 993a746: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
  • 2981858: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • ba59249: 8310923: Refactor Currency tests to use JUnit
  • a51c74d: 8306922: IR verification fails because IR dump is chopped up
  • f011538: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • 32a4568: 8318613: ChoiceFormat patterns are not well tested
  • 1e8c226: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • 8d536b6: 8318154: Improve stability of WheelModifier.java test
  • fcf9ebd: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 9ca8761: 8323086: Shenandoah: Heap could be corrupted by oom during evacuation
  • ... and 55 more: https://git.openjdk.org/jdk21u-dev/compare/e08eb0ec0181228468c51129a6a9378d749d6d02...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2024
@openjdk openjdk bot closed this Jan 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@GoeLin Pushed as commit 0668efa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant