Skip to content

8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 8, 2025

I backport this for parity with 21.0.8-oracle.

Needed to adapt
return openSslRootPath.resolve(libDir, "ossl-modules");
because 8262742: "(fs) Add Path::resolve with varargs string"
is not in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349492 needs maintainer approval

Issue

  • JDK-8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1756/head:pull/1756
$ git checkout pull/1756

Update a local copy of the PR:
$ git checkout pull/1756
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1756/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1756

View PR using the GUI difftool:
$ git pr show -t 1756

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1756.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 8, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8d8bd0c4b3bfdc7670bba03b01b0a00dac9f9825 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version May 8, 2025
@openjdk
Copy link

openjdk bot commented May 8, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 8, 2025
@mlbridge
Copy link

mlbridge bot commented May 8, 2025

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented May 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels May 9, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 9, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 9, 2025

Going to push as commit 23469f8.
Since your change was applied there have been 15 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 9, 2025
@openjdk openjdk bot closed this May 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 9, 2025
@openjdk
Copy link

openjdk bot commented May 9, 2025

@GoeLin Pushed as commit 23469f8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8349492 branch May 9, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants