-
Notifications
You must be signed in to change notification settings - Fork 129
8332921: Ctrl+C does not call shutdown hooks after JLine upgrade #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
Going to push as commit e3a7b10.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 21.0.8-oracle.
Resolved one file because "https://bugs.openjdk.org/browse/JDK-8330998: System.console() writes to stderr when stdout is redirected" and others are not in 21.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1779/head:pull/1779
$ git checkout pull/1779
Update a local copy of the PR:
$ git checkout pull/1779
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1779/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1779
View PR using the GUI difftool:
$ git pr show -t 1779
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1779.diff
Using Webrev
Link to Webrev Comment