8216437: PPC64: Add intrinsic for GHASH algorithm

[suchismith1993]

Hi all,

This pull request contains a backport of commit cdad6d78 from the openjdk/jdk repository.

The commit being backported was authored by Suchismith Roy on 2 May 2025 and was reviewed by Martin Doerr and Amit Kumar.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8216437 needs maintainer approval

Issue

• JDK-8216437: PPC64: Add intrinsic for GHASH algorithm (Enhancement - P4 - Approved)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1789/head:pull/1789
$ git checkout pull/1789

Update a local copy of the PR:
$ git checkout pull/1789
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1789/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1789

View PR using the GUI difftool:
$ git pr show -t 1789

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1789.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8216437: PPC64: Add intrinsic for GHASH algorithm

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 336 new commits pushed to the master branch:

• 8169077: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number
• 32d8d44: 8359207: Remove runtime/signal/TestSigusr2.java since it is always skipped
• e6b4beb: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
• ... and 333 more: https://git.openjdk.org/jdk21u-dev/compare/ecfa00db746900dff15e3fd4b7de3669cf989dc7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @suchismith1993 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 02: Full - Incremental (11b87982)
• 01: Full - Incremental (bf0ad564)
• 00: Full (76a3b83f)

[openjdk]

@suchismith1993
8216437: The approval request has been created successfully.

[suchismith1993]

Need to adapt code for jdk21 repo. Looking into it

[suchismith1993]

/approval request Need GHASH for jdk21

[openjdk]

@suchismith1993
8216437: The approval request has been updated successfully.

[TheRealMDoerr]

Backport looks correct.

[suchismith1993]

/approval ghash fix needed for jdk21

[suchismith1993]

/approval request ghash fix needed for jdk21

[openjdk]

@suchismith1993 usage: /approval [<id>] (request|cancel) [<text>]

[openjdk]

@suchismith1993
8216437: The approval request has been updated successfully.

[suchismith1993]

/integrate

[openjdk]

@suchismith1993 This pull request has not yet been marked as ready for integration.

[GoeLin]

Hi @suchismith1993
please give a fix request comment that gives the necessary details.
The change is definitely not needed for 21, probably a nice-to-have performance optimization.

This has not been tested in any released JVM yet, do you really want to bring it to 21 now?

[suchismith1993]

Hi @suchismith1993 please give a fix request comment that gives the necessary details. The change is definitely not needed for 21, probably a nice-to-have performance optimization.

This has not been tested in any released JVM yet, do you really want to bring it to 21 now?

It has been tested on the headstream, but not sure which release it would be a part of. 21 is LTS and used by many customers, so the optimisation should be a good addition.
@TheRealMDoerr Your thoughts ?

[TheRealMDoerr]

It will be released with JDK25 in September. The October Update of JDK21 should be ok for the backport. The tests should have covered it well enough. If we want some extra safety, postponing to January Update would be ok with me, too.

[suchismith1993]

@TheRealMDoerr @GoeLin so we wait at least till October ? So should this PR be closed now ?

[TheRealMDoerr]

No, you can integrate it after you got maintainer approval.

[suchismith1993]

@GoeLin can it be approved now ? or shall we hold till October ?

[GoeLin]

Hi Suchismith,
I labeled it jdk21u-defer-next.
Also, you did not update the fix-request comment yet. There should be good information about this in the JBS issue. The purpose of the PR is only to review it.

[suchismith1993]

/approval request The fix provides a 3x performance benefit. JDK21 is LTS and used by many customers, so this fix is essential.

[openjdk]

@suchismith1993
8216437: The approval request has been updated successfully.

[bridgekeeper]

@suchismith1993 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@suchismith1993 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[suchismith1993]

/open

[openjdk]

@suchismith1993 This pull request is now open

[suchismith1993]

/integrate

[openjdk]

@suchismith1993
Your change (at version 11b8798) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 413fa29.
Since your change was applied there have been 336 commits pushed to the master branch:

• 8169077: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number
• 32d8d44: 8359207: Remove runtime/signal/TestSigusr2.java since it is always skipped
• e6b4beb: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
• ... and 333 more: https://git.openjdk.org/jdk21u-dev/compare/ecfa00db746900dff15e3fd4b7de3669cf989dc7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @suchismith1993 Pushed as commit 413fa29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.