Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented May 19, 2025

Backporting JDK-8348303: Remove repeated 'a' from ListSelectionEvent. Trivial test change to clean up description. Ran GHA Sanity Checks, local Tier 1 and 2 tests. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8348303 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8348303: Remove repeated 'a' from ListSelectionEvent (Bug - P5 - Rejected)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1808/head:pull/1808
$ git checkout pull/1808

Update a local copy of the PR:
$ git checkout pull/1808
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1808

View PR using the GUI difftool:
$ git pr show -t 1808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1808.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 17df51516aadf5ade73cf8d05c1be09772852b96 8348303: Remove repeated 'a' from ListSelectionEvent May 19, 2025
@openjdk
Copy link

openjdk bot commented May 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 19, 2025
@openjdk
Copy link

openjdk bot commented May 19, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 19, 2025
@mlbridge
Copy link

mlbridge bot commented May 19, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport. Trivial test change to clean up description.

Risk: Low. Tip change was merged in January, but only touches test logic and is quite simple.

Testing:

  • GHA Sanity Checks
  • Tier 1 and 2 tests locally

@openjdk
Copy link

openjdk bot commented May 22, 2025

@satyenme
8348303: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels May 22, 2025
@satyenme satyenme closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant