Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size #181

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 17, 2024

Backport 8322098


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8322098 needs maintainer approval
  • JDK-8323331 needs maintainer approval

Issues

  • JDK-8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size (Bug - P4 - Approved)
  • JDK-8323331: fix typo hpage_pdm_size (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/181/head:pull/181
$ git checkout pull/181

Update a local copy of the PR:
$ git checkout pull/181
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 181

View PR using the GUI difftool:
$ git pr show -t 181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/181.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b31454e36234091c3827c3b4d07f62345cb0cee4 8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size Jan 17, 2024
@openjdk
Copy link

openjdk bot commented Jan 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review approval labels Jan 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2024

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@RealCLanger
Copy link
Contributor

Hi @MBaesken,
could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx.

@MBaesken
Copy link
Member Author

Hi @MBaesken, could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx.

Sure , I added it above, hope this is okay and works as expected .

@RealCLanger
Copy link
Contributor

/issue add JDK-8323331

@RealCLanger
Copy link
Contributor

Hi @MBaesken, could you please also add JDK-8323331 as issue to this PR? It should be marked as resolved by this backport, too. Thx.

Sure , I added it above, hope this is okay and works as expected .

No, I meant to add the issue to the list of issues resolved by this PR via the "/issue add" skara command. I tried to add it above but I believe Skara won't accept this because it is not my PR.

@openjdk
Copy link

openjdk bot commented Jan 17, 2024

@RealCLanger Only the author (@MBaesken) is allowed to issue the /issue command.

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size
8323331: fix typo hpage_pdm_size

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

  • 309a16e: 8323659: LinkedTransferQueue add and put methods call overridable offer
  • e3084fc: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • 0668efa: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong
  • 993a746: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
  • 2981858: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • ba59249: 8310923: Refactor Currency tests to use JUnit
  • a51c74d: 8306922: IR verification fails because IR dump is chopped up
  • f011538: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • 32a4568: 8318613: ChoiceFormat patterns are not well tested
  • 1e8c226: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • ... and 47 more: https://git.openjdk.org/jdk21u-dev/compare/0ac1bb75a0d97e88fbdae85d85e9658cf549c3fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 18, 2024
@GoeLin
Copy link
Member

GoeLin commented Jan 18, 2024

Yes, please add issue 8323331. It makes sense to combine them, but we need to annotate this.

@openjdk openjdk bot added approval and removed ready Pull request is ready to be integrated labels Jan 18, 2024
@MBaesken
Copy link
Member Author

/issue add JDK-8323331

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@MBaesken
Adding additional issue to issue list: 8323331: fix typo hpage_pdm_size.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 18, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 18, 2024

Going to push as commit 419e016.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 309a16e: 8323659: LinkedTransferQueue add and put methods call overridable offer
  • e3084fc: 8304020: Speed up test/jdk/java/util/zip/ZipFile/TestTooManyEntries.java and clarify its purpose
  • 0668efa: 8317522: Test logic for BODY_CF in AbstractThrowingSubscribers.java is wrong
  • 993a746: 8311986: Disable runtime/os/TestTracePageSizes.java for ShenandoahGC
  • 2981858: 8315721: CloseRace.java#id0 fails transiently on libgraal
  • ba59249: 8310923: Refactor Currency tests to use JUnit
  • a51c74d: 8306922: IR verification fails because IR dump is chopped up
  • f011538: 8323428: Shenandoah: Unused memory in regions compacted during a full GC should be mangled
  • 32a4568: 8318613: ChoiceFormat patterns are not well tested
  • 1e8c226: 8316106: Open source few swing JInternalFrame and JMenuBar tests
  • ... and 47 more: https://git.openjdk.org/jdk21u-dev/compare/0ac1bb75a0d97e88fbdae85d85e9658cf549c3fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 18, 2024
@openjdk openjdk bot closed this Jan 18, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 18, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 18, 2024
@openjdk
Copy link

openjdk bot commented Jan 18, 2024

@MBaesken Pushed as commit 419e016.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants