-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322098: os::Linux::print_system_memory_info enhance the THP output with /sys/kernel/mm/transparent_hugepage/hpage_pmd_size #181
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
Hi @MBaesken, |
Sure , I added it above, hope this is okay and works as expected . |
/issue add JDK-8323331 |
No, I meant to add the issue to the list of issues resolved by this PR via the "/issue add" skara command. I tried to add it above but I believe Skara won't accept this because it is not my PR. |
@RealCLanger Only the author (@MBaesken) is allowed to issue the |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 57 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Yes, please add issue 8323331. It makes sense to combine them, but we need to annotate this. |
/issue add JDK-8323331 |
@MBaesken |
/integrate |
Going to push as commit 419e016.
Your commit was automatically rebased without conflicts. |
Backport 8322098
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/181/head:pull/181
$ git checkout pull/181
Update a local copy of the PR:
$ git checkout pull/181
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/181/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 181
View PR using the GUI difftool:
$ git pr show -t 181
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/181.diff
Webrev
Link to Webrev Comment