Skip to content

8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java#1826

Closed
phohensee wants to merge 1 commit intoopenjdk:masterfrom
phohensee:8335252
Closed

8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java#1826
phohensee wants to merge 1 commit intoopenjdk:masterfrom
phohensee:8335252

Conversation

@phohensee
Copy link
Member

@phohensee phohensee commented May 22, 2025

Clean backport to fix a regression resulting from JDK-8263038.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8183348 needs maintainer approval

Issue

  • JDK-8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1826/head:pull/1826
$ git checkout pull/1826

Update a local copy of the PR:
$ git checkout pull/1826
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1826

View PR using the GUI difftool:
$ git pr show -t 1826

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1826.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 03f0ec4a35855b59c8faaf4be2e7569a12b4d5db 8183348: Better cleanup for jdk/test/sun/security/pkcs12/P12SecretKey.java May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels May 22, 2025
@phohensee phohensee closed this May 22, 2025
@phohensee phohensee deleted the 8335252 branch May 22, 2025 20:57
@phohensee phohensee restored the 8335252 branch May 22, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant