8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization

[jankratochvil]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8355077 needs maintainer approval

Issue

• JDK-8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization (Bug - P4 - Approved)

Reviewers

• Laurent Bourgès (@bourgesl - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1831/head:pull/1831
$ git checkout pull/1831

Update a local copy of the PR:
$ git checkout pull/1831
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1831

View PR using the GUI difftool:
$ git pr show -t 1831

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1831.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jkratochvil! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jankratochvil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355077: Compiler error at splashscreen_gif.c due to unterminated string initialization

Reviewed-by: lbourges

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• dd842c4: 8349988: Change cgroup version detection logic to not depend on /proc/cgroups
• 7ef2dfd: 8354233: Open some JTable bugs 6
• 20e9f61: 8354095: Open some JTable bugs 5

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@bourgesl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @jankratochvil This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (42d1b35d)
• 00: Full (1638293d)

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[jankratochvil]

/open

[openjdk]

@jankratochvil This pull request is now open

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@jankratochvil This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[jankratochvil]

/open

[openjdk]

@jankratochvil This pull request is now open

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 1638293) is now ready to be sponsored by a Committer.

[shipilev]

As the matter of course, for the older PRs like these, you need to merge from the recent master before integrating. Otherwise there is a risk of introducing a build failure due to bad merge. The risk here seems low, but nevertheless. Bots currently say: "At the time when this comment was updated there had been 496 new commits pushed to the master branch:"

[shipilev]

I think you are fine now, thanks! Ask bots to integrate again.

[jankratochvil]

/integrate

[openjdk]

@jankratochvil
Your change (at version 42d1b35) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

[openjdk]

Going to push as commit e324954.
Since your change was applied there have been 6 commits pushed to the master branch:

• 53853a1: 8355241: Move NativeDialogToFrontBackTest.java PL test to manual category
• fd2753a: 8334509: Cancelling PageDialog does not return the same PageFormat object
• 525ab39: 8328377: Convert java/awt/Cursor/MultiResolutionCursorTest test to main
• ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/b17a237408e7d83d856ab64b4872f498819ef44e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @jankratochvil Pushed as commit e324954.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.