Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented May 28, 2025


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355979 needs maintainer approval

Issue

  • JDK-8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1837/head:pull/1837
$ git checkout pull/1837

Update a local copy of the PR:
$ git checkout pull/1837
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1837

View PR using the GUI difftool:
$ git pr show -t 1837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1837.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • dcb39d8: 8358659: Bump update version for OpenJDK: jdk-21.0.9
  • c7409c7: 8343618: Stack smashing in awt_InputMethod.c on Linux s390x
  • 27b6284: 8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 088825ed889551e6067d46bf77fe4d30a3972da1 8355979: ATTRIBUTE_NO_UBSAN needs to be extended to handle float divisions by zero on AIX May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval Requires approval; will be removed when approval is received labels May 28, 2025
@mlbridge
Copy link

mlbridge bot commented May 28, 2025

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 5, 2025
@MBaesken
Copy link
Member Author

MBaesken commented Jun 5, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 5, 2025

Going to push as commit ec3bc56.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 5, 2025
@openjdk openjdk bot closed this Jun 5, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2025
@openjdk
Copy link

openjdk bot commented Jun 5, 2025

@MBaesken Pushed as commit ec3bc56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant