-
Notifications
You must be signed in to change notification settings - Fork 147
8347826: Introspector shows wrong method list after 8071693 #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
@wkia This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@alexeybakhtin) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request I'd like to backport this to 21u. The backport is almost clean. PR checks (tier1) are OK. This backport fixes the wrong method and property list returning by Introspector broken after 8071693. |
alexeybakhtin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. No regressions in java/beans/Inspector tests after applying the patch. Updated DefaultMethodBeanTest passes.
|
Test also reproduces the issue. As this is brand new also in head, I ran it through our testing, successfully. |
|
/integrate |
|
/sponsor |
|
Going to push as commit edd4120.
Your commit was automatically rebased without conflicts. |
|
@phohensee @wkia Pushed as commit edd4120. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is backport of "8347826: Introspector shows wrong method list after 8071693"
The backport is almost clean, the only conflict was in copyright year in
src/java.desktop/share/classes/java/beans/Introspector.java.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1847/head:pull/1847$ git checkout pull/1847Update a local copy of the PR:
$ git checkout pull/1847$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1847/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1847View PR using the GUI difftool:
$ git pr show -t 1847Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1847.diff
Using Webrev
Link to Webrev Comment