8309627: Incorrect sorting of DirtyCardQueue buffers

[cost0much]

Clean backport. Fixes G1 DirtyCardQueue's sort from breaking on large heaps (8TB+ on default card size 512 bytes, 2TB+ for smallest card size 128 bytes). Ran on internal Amazon pipelines and passes jtreg tier1-4 + tck tests on the following platforms: linux x64, aarch64; macos x64, aarch64; windows x64. Also passes GHA.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8309627 needs maintainer approval

Issue

• JDK-8309627: Incorrect sorting of DirtyCardQueue buffers (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1861/head:pull/1861
$ git checkout pull/1861

Update a local copy of the PR:
$ git checkout pull/1861
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1861

View PR using the GUI difftool:
$ git pr show -t 1861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1861.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309627: Incorrect sorting of DirtyCardQueue buffers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 94e096c: 8335252: Reduce size of j.u.Formatter.Conversion#isValid
• cf8601c: 8302293: jar --create fails with IllegalArgumentException if archive name is shorter than 3 characters
• 96866ce: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• ... and 14 more: https://git.openjdk.org/jdk21u-dev/compare/20ee988cadfa65ce8cb5c23931dded2d3213764c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (29d2c0c9)

[cost0much]

/approval request Fixes G1 DirtyCardQueue's sort breaking on large heaps (8TB+ on default card size 512 bytes, 2TB+ for smallest card size 128 bytes). Applies cleanly. Patched in JDK22 and no bugtail. Passes jtreg tier1-4 and tck tests on multiple platforms; see PR for list. GHA also passes. Risk is medium because hotspot change that affects G1. However, risk is mitigated by minor change and extensive testing.

[openjdk]

@cost0much
8309627: The approval request has been created successfully.

[cost0much]

/integrate

[openjdk]

@cost0much
Your change (at version 29d2c0c) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit b9a6838.
Since your change was applied there have been 17 commits pushed to the master branch:

• 94e096c: 8335252: Reduce size of j.u.Formatter.Conversion#isValid
• cf8601c: 8302293: jar --create fails with IllegalArgumentException if archive name is shorter than 3 characters
• 96866ce: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• ... and 14 more: https://git.openjdk.org/jdk21u-dev/compare/20ee988cadfa65ce8cb5c23931dded2d3213764c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @cost0much Pushed as commit b9a6838.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.