Skip to content

Conversation

@feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Jun 20, 2025

Hi all,

This pull request contains a backport of commit c5a1543e from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 2 Jun 2025 and was reviewed by Erik Österlund, Fredrik Bredberg, Aleksey Shipilev and Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357968 needs maintainer approval

Issue

  • JDK-8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1910/head:pull/1910
$ git checkout pull/1910

Update a local copy of the PR:
$ git checkout pull/1910
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1910

View PR using the GUI difftool:
$ git pr show -t 1910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1910.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c5a1543ee3e68775f09ca29fb07efd9aebfdb33e 8357968: RISC-V: Interpreter volatile reference stores with G1 are not sequentially consistent Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

⚠️ @feilongjiang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

@feilongjiang
Copy link
Member Author

/approval request
Same issue exists in jdk21u repo as well. And the bug is reproducible with jcstress RefDekker test with jdk21u.
Backport is clean. This is a RISC-V specific change, should be low risk.
Tier1-3 tested on linux-riscv64 platform. jcstress RefDekker test passes with this backport.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

@feilongjiang
8357968: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 20, 2025
@robehn
Copy link
Contributor

robehn commented Jun 23, 2025

Thanks!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jun 24, 2025
@feilongjiang
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@feilongjiang
Your change (at version 535a732) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 24, 2025

Going to push as commit f2614cc.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 24, 2025
@openjdk openjdk bot closed this Jun 24, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 24, 2025
@openjdk
Copy link

openjdk bot commented Jun 24, 2025

@RealFYang @feilongjiang Pushed as commit f2614cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the backport-feilongjiang-c5a1543e-master branch June 24, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants