8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

[Baraa-Hasheesh]

Backport JDK-8249825 for parity with oracle.

Clean backport, enabling two tests that were previously marked as @ignore

This change includes refactoring logic to fix the existing flakiness of the tests & correctly specify which TLS should be used when running the tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8249825 needs maintainer approval

Issue

• JDK-8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1921/head:pull/1921
$ git checkout pull/1921

Update a local copy of the PR:
$ git checkout pull/1921
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1921/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1921

View PR using the GUI difftool:
$ git pr show -t 1921

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1921.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Baraa-Hasheesh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Baraa-Hasheesh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• f1a2b4a: 8340185: Use make -k on GHA to catch more build errors
• 70e4cb7: Merge
• bb83d59: 8360406: [21u] Disable logic for attaching type annotations to class files until 8359336 is fixed
• ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/79f8bf5cf95707d84455d0cdce058932baa0e019...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @Baraa-Hasheesh This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (bad5a3df)

[Baraa-Hasheesh]

/approval request enable previously disabled tests, & make the needed refactoring to solve the flakiness issues that were previously present in the tests. Backported for parity with oracle. Applies cleanly, tier1 tests & modified test passes (ran both 500 times with no observed failures). Risk is minimal as this only changes existing tests & changed tests pass.

[openjdk]

@Baraa-Hasheesh
8249825: The approval request has been created successfully.

[Baraa-Hasheesh]

/integrate

[openjdk]

@Baraa-Hasheesh
Your change (at version bad5a3d) is now ready to be sponsored by a Committer.

[shipilev]

/sponsor

[openjdk]

Going to push as commit 26e4e14.
Since your change was applied there have been 4 commits pushed to the master branch:

• f1a2b4a: 8340185: Use make -k on GHA to catch more build errors
• 70e4cb7: Merge
• bb83d59: 8360406: [21u] Disable logic for attaching type annotations to class files until 8359336 is fixed
• ... and 1 more: https://git.openjdk.org/jdk21u-dev/compare/79f8bf5cf95707d84455d0cdce058932baa0e019...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @Baraa-Hasheesh Pushed as commit 26e4e14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.