Skip to content

Conversation

@reinrich
Copy link
Member

@reinrich reinrich commented Jul 15, 2025

This pull request contains a backport of commit 030c85de from the openjdk/jdk repository.

The commit being backported was authored by Richard Reingruber on 11 Mar 2025 and was reviewed by Martin Doerr.

It does not apply because of copyright header differences and because frame::kind doesn't exist yet in jdk21u but appears in the context of the changes.

Risk is low because the patch is small and ppc only. The code is only reached when profiling with jfr or async-profiler.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8350106 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1971/head:pull/1971
$ git checkout pull/1971

Update a local copy of the PR:
$ git checkout pull/1971
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1971

View PR using the GUI difftool:
$ git pr show -t 1971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1971.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back rrich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@reinrich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 030c85de1376123615e804f98084cb3723205819 8350106: [PPC] Avoid ticks_unknown_not_Java AsyncGetCallTrace() if JavaFrameAnchor::_last_Java_pc not set Jul 15, 2025
@openjdk
Copy link

openjdk bot commented Jul 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Jul 15, 2025
@reinrich reinrich marked this pull request as ready for review July 16, 2025 07:55
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

⚠️ @reinrich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 17, 2025
@reinrich
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

Going to push as commit d590823.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 22, 2025
@openjdk openjdk bot closed this Jul 22, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 22, 2025
@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@reinrich Pushed as commit d590823.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants