Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321151: JDK-8294427 breaks Windows L&F on all older Windows versions #200

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 20, 2024

Hi all,

This pull request contains a backport of commit f695ca58 from the openjdk/jdk repository.

The commit being backported was authored by Rajat Mahajan on 22 Dec 2023 and was reviewed by Alexey Ivanov and Alisen Chung.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321151 needs maintainer approval

Issue

  • JDK-8321151: JDK-8294427 breaks Windows L&F on all older Windows versions (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/200.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2024

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f695ca588453265d6ad791c6a396197e8a53ba39 8321151: JDK-8294427 breaks Windows L&F on all older Windows versions Jan 20, 2024
@openjdk
Copy link

openjdk bot commented Jan 20, 2024

This backport pull request has now been updated with issue from the original commit.

@mrserb mrserb marked this pull request as ready for review January 20, 2024 06:06
@openjdk
Copy link

openjdk bot commented Jan 20, 2024

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2024

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the approval label Feb 22, 2024
@openjdk
Copy link

openjdk bot commented Feb 23, 2024

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321151: JDK-8294427 breaks Windows L&F on all older Windows versions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • e69b611: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 290cd11: 8321408: Add Certainly roots R1 and E1
  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • 92d533e: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • ... and 67 more: https://git.openjdk.org/jdk21u-dev/compare/c01bdbbfb1784bff6ae4b66d156b3c78546ad264...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 23, 2024
@mrserb
Copy link
Member Author

mrserb commented Feb 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Feb 26, 2024

Going to push as commit 1b7c5af.
Since your change was applied there have been 83 commits pushed to the master branch:

  • 55f9bcf: 8325876: crashes in docker container tests on Linuxppc64le Power8 machines
  • 69aa4ab: 8325470: [AIX] use fclose after fopen in read_psinfo
  • 08f9237: 8320303: Allow PassFailJFrame to accept single window creator
  • 8ddff70: 8326000: Remove obsolete comments for class sun.security.ssl.SunJSSE
  • 2c38047: 8314835: gtest wrappers should be marked as flagless
  • c80bb72: 8325254: CKA_TOKEN private and secret keys are not necessarily sensitive
  • e69b611: 8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name
  • 290cd11: 8321408: Add Certainly roots R1 and E1
  • 9adc281: 8325074: ZGC fails assert(index == 0 || is_power_of_2(index)) failed: Incorrect load shift: 11
  • 3b4932b: 8315726: Open source several AWT applet tests
  • ... and 73 more: https://git.openjdk.org/jdk21u-dev/compare/c01bdbbfb1784bff6ae4b66d156b3c78546ad264...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 26, 2024
@openjdk openjdk bot closed this Feb 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 26, 2024

@mrserb Pushed as commit 1b7c5af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant