Skip to content

8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed#2016

Closed
satyenme wants to merge 1 commit intoopenjdk:masterfrom
satyenme:8332857
Closed

8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed#2016
satyenme wants to merge 1 commit intoopenjdk:masterfrom
satyenme:8332857

Conversation

@satyenme
Copy link

@satyenme satyenme commented Jul 24, 2025

Backporting JDK-8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed. Patch adds synchronization to the test, backporting for parity with oracle. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean.


Progress

  • JDK-8332857 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2016/head:pull/2016
$ git checkout pull/2016

Update a local copy of the PR:
$ git checkout pull/2016
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2016

View PR using the GUI difftool:
$ git pr show -t 2016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2016.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6ef860c728d3f2f29fe8f7318c0f56032e0679be 8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 24, 2025
@openjdk
Copy link

openjdk bot commented Jul 24, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8332857: Test vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java failed

Motivation: With this backport, the vmTestbase/nsk/jvmti/GetThreadCpuTime/thrcputime002/TestDescription.java test will have synchronicity checks, and not encounter the test failure. Change has been accepted by oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Although change has only been in tip since Jan 2025, it has been accepted and backported by oracle

@openjdk
Copy link

openjdk bot commented Jul 24, 2025

@satyenme
8332857: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 24, 2025
@satyenme
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

Going to push as commit b783173.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2025
@openjdk openjdk bot closed this Jul 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@satyenme Pushed as commit b783173.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant