Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Jul 25, 2025

Backporting JDK-8341311: [Accessibility,macOS,VoiceOver] VoiceOver announces incorrect number of items in submenu of JPopupMenu. Patch ensures correct child details are sent back to a11y sub-system to be correct when using voice over and adds test. Backporting for parity with oracle. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8341311 needs maintainer approval

Issue

  • JDK-8341311: [Accessibility,macOS,VoiceOver] VoiceOver announces incorrect number of items in submenu of JPopupMenu (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2017/head:pull/2017
$ git checkout pull/2017

Update a local copy of the PR:
$ git checkout pull/2017
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2017/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2017

View PR using the GUI difftool:
$ git pr show -t 2017

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2017.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341311: [Accessibility,macOS,VoiceOver] VoiceOver announces incorrect number of items in submenu of JPopupMenu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e33eeeea04fc7899bf66b0a2fdaccc30060854b4 8341311: [Accessibility,macOS,VoiceOver] VoiceOver announces incorrect number of items in submenu of JPopupMenu Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8341311: [Accessibility,macOS,VoiceOver] VoiceOver announces incorrect number of items in submenu of JPopupMenu

Motivation: Without this backport, voice over announces incorrect number of items in submenu of JPopupMenu. With this fix, the voice over will announce the correct value, and we'll introduce a test to catch future regression.

Risk: Somewhat Low. Ran GHA Sanity Checks, local Tier 1 and 2, and new test directly. Patch is clean. Although change has only been in tip since May 2025, it has been accepted and backported by oracle. Change only affects Mac accessibility code.

@openjdk
Copy link

openjdk bot commented Jul 28, 2025

@satyenme
8341311: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 28, 2025
@satyenme
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

Going to push as commit e57fbd4.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2025
@openjdk openjdk bot closed this Jul 29, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@satyenme Pushed as commit e57fbd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant