Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Jul 29, 2025

Backporting JDK-8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir. Fixing test to not modify the JDK home directory under test, as that could impact the results of other tests, or could fail if the JDK home dir is read-only. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342238 needs maintainer approval

Issue

  • JDK-8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2020/head:pull/2020
$ git checkout pull/2020

Update a local copy of the PR:
$ git checkout pull/2020
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2020

View PR using the GUI difftool:
$ git pr show -t 2020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2020.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 16033ea79a01b27a7f5cbb31d64da0e80afc7dc3 8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 29, 2025
@openjdk
Copy link

openjdk bot commented Jul 29, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

Motivation: Without this change, running the javax/crypto/CryptoPermissions/InconsistentEntries.java test modifies a directory only required to be read/execute only. With this change, the test will no longer failing such scenarios, and will closer align with Oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Change has been present in tip since Feb, 2025. Only test code for a single test. Change has been accepted by Oracle.

@openjdk
Copy link

openjdk bot commented Jul 29, 2025

@satyenme
8342238: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 29, 2025
@satyenme
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2025

Going to push as commit b60e668.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2025
@openjdk openjdk bot closed this Jul 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2025
@openjdk
Copy link

openjdk bot commented Jul 30, 2025

@satyenme Pushed as commit b60e668.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin
Copy link
Member

GoeLin commented Aug 11, 2025

Hi @satyenme
It seems this change causes errors in our testing. Please check all "related issue" etc noted in the JBS issue if you backport a change. If there are follow-ups, backport these too. I did JDK-8350456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants