Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 1, 2025

I backport this for parity with 21.0.9-oracle

Resolved Copyright, probably clean anyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346751 needs maintainer approval

Issue

  • JDK-8346751: Internal java compiler error with type annotations in constants expression in constant fields (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2026/head:pull/2026
$ git checkout pull/2026

Update a local copy of the PR:
$ git checkout pull/2026
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2026

View PR using the GUI difftool:
$ git pr show -t 2026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2026.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346751: Internal java compiler error with type annotations in constants expression in constant fields

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport 0395593a8a1c01a87ae36552c0f2cc9c67e8bbd8 8346751: Internal java compiler error with type annotations in constants expression in constant fields Aug 1, 2025
@openjdk
Copy link

openjdk bot commented Aug 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 1, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8346751 branch from bfddc52 to 873c73b Compare August 1, 2025 12:20
@openjdk
Copy link

openjdk bot commented Aug 1, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Aug 1, 2025
@openjdk
Copy link

openjdk bot commented Aug 1, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Aug 2, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 2, 2025

GHA failure: Infra issue, unrelated.
E: Couldn't download https://httpredir.debian.org/debian/dists/bullseye/main/binary-ppc64el/Packages

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 4, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 4, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2025

Going to push as commit 669026a.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 4, 2025
@openjdk openjdk bot closed this Aug 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 4, 2025
@openjdk
Copy link

openjdk bot commented Aug 4, 2025

@GoeLin Pushed as commit 669026a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8346751 branch August 4, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant