8310264: In PhaseChaitin::Split defs and phis are leaked

[satyenme]

Backporting JDK-8310264: In PhaseChaitin::Split defs and phis are leaked. Currently, defs and phis are leaked as they are resource allocated but not protected by a ResourceMark. Fixes memory leak conservatively.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8310264 needs maintainer approval

Issue

• JDK-8310264: In PhaseChaitin::Split defs and phis are leaked (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2030/head:pull/2030
$ git checkout pull/2030

Update a local copy of the PR:
$ git checkout pull/2030
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2030

View PR using the GUI difftool:
$ git pr show -t 2030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2030.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310264: In PhaseChaitin::Split defs and phis are leaked

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (f5f9500f)

[satyenme]

/approval request for backport of JDK-8310264: In PhaseChaitin::Split defs and phis are leaked

Motivation: Without this change, there's a possibility the append_entry value could overflow. With this fix, adds a check for problematic cases and fails fast.

Risk: Low-ish. Ran GHA Sanity Checks, local Tier 1 and 2, and tests listed on original PR directly. Patch is clean. Change has been present in tip since February, 2024.

[openjdk]

@satyenme
8310264: The approval request has been created successfully.

[satyenme]

/integrate

[openjdk]

Going to push as commit 2ae23bd.
Since your change was applied there have been 15 commits pushed to the master branch:

• aab1e21: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119)
• c6af937: 8334016: Make PrintNullString.java automatic
• fa53b2e: 8355262: Test sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java failed: accept timed out
• ... and 12 more: https://git.openjdk.org/jdk21u-dev/compare/b60e6685f299fceafae6e2b615a177b42ddc4ba3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@satyenme Pushed as commit 2ae23bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.