Skip to content

8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 #204

wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 22, 2024 •
edited by openjdk bot
Loading

Progress

  • JDK-8316563 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/204.diff

Webrev

Link to Webrev Comment

Backport 52814994efc4831fdbc1f796ed1db6ae88cb616c
f0f8d1b 
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sendaoYan
Copy link
Member Author

image

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2024

👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 52814994efc4831fdbc1f796ed1db6ae88cb616c 8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27 Jan 22, 2024
@openjdk
Copy link

openjdk bot commented Jan 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 22, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 22, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 19, 2024

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

sendaoYan commented Feb 21, 2024 •
edited
Loading

/approval JDK-8316563 "This PR only change the testcase, the testcase change has been verified. Please review this PR."

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
JDK-8316563: The approval request has been created successfully.

@openjdk openjdk bot added approval and removed approval labels Feb 21, 2024
@sendaoYan
Copy link
Member Author

sendaoYan commented Mar 5, 2024 •
edited
Loading

image

/approval request "This PR only change the testcase, the testcase change has been verified. Please review this PR."

@openjdk
Copy link

openjdk bot commented Mar 5, 2024

@sendaoYan
8316563: The approval request has been updated successfully.

@openjdk openjdk bot added the approval label Mar 5, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 6, 2024

/approval JDK-8316563 "This PR only change the testcase, the testcase change has been verified. Please review this PR."

You don't need a reeview as it is clean. Also, if you need a review, you should not request approval.
But as this is clean and all good, I'll approve it.

@openjdk
Copy link

openjdk bot commented Mar 6, 2024 •
edited
Loading

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316563: test tools/jpackage/linux/LinuxResourceTest.java fails on CentOS Linux release 8.5.2111 and Fedora 27

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

  • ad1d324: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 930344a: Merge
  • 29bf21f: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 4244cb0: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • d6ad625: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • fdbed07: 8325862: set -XX:+ErrorFileToStderr when executing java in containers for some container related jtreg tests
  • dbcce04: 8323519: Add applications/ctw/modules to Hotspot tiered testing
  • 500d85a: 8318580: "javax/swing/MultiMonitor/MultimonVImage.java failing with Error. Can't find library: /open/test/jdk/java/awt/regtesthelpers" after JDK-8316053
  • ee6445c: 8323210: Update the usage of cmsFLAGS_COPY_ALPHA
  • ... and 94 more: https://git.openjdk.org/jdk21u-dev/compare/ada400cffe35140d62452e3899e5a04a40b737c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored and removed approval labels Mar 6, 2024
@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan
Your change (at version f0f8d1b) is now ready to be sponsored by a Committer.

@sendaoYan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 6, 2024

@sendaoYan
Your change (at version f0f8d1b) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Mar 7, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

Going to push as commit 5c3dfe4.
Since your change was applied there have been 108 commits pushed to the master branch:

  • e8d2535: 8315609: Open source few more swing text/html tests
  • 555f824: 8315898: Open source swing JMenu tests
  • bfaec80: 8325972: Add -x to bash for building with LOG=debug
  • e071843: 8326638: Crash in PhaseIdealLoop::remix_address_expressions due to unexpected Region instead of Loop
  • ad1d324: 8327036: [macosx-aarch64] SIGBUS in MarkActivationClosure::do_code_blob reached from Unsafe_CopySwapMemory0
  • 930344a: Merge
  • 29bf21f: 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  • 4244cb0: 8306040: HttpResponseInputStream.available() returns 1 on empty stream
  • d6ad625: 8324648: Avoid NoSuchMethodError when instantiating NativePRNG
  • 2d62854: 8320343: Generate GIF images for AbstractButton/5049549/bug5049549.java
  • ... and 98 more: https://git.openjdk.org/jdk21u-dev/compare/ada400cffe35140d62452e3899e5a04a40b737c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 7, 2024
@openjdk openjdk bot closed this Mar 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 7, 2024
@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@shipilev @sendaoYan Pushed as commit 5c3dfe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

@shipilev Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport clean integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sendaoYan @GoeLin @shipilev