Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly #207

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jan 23, 2024

I backport this for parity with 21.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316947 needs maintainer approval

Issue

  • JDK-8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/207/head:pull/207
$ git checkout pull/207

Update a local copy of the PR:
$ git checkout pull/207
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 207

View PR using the GUI difftool:
$ git pr show -t 207

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/207.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 00ef9f9c322dde236256953272d6906f6151635d 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly Jan 23, 2024
@openjdk
Copy link

openjdk bot commented Jan 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 23, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2024

Webrevs

@openjdk openjdk bot added the approval label Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • 711ab38: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold
  • cc189ff: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
  • e87638c: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
  • 90d7b17: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 7fcfea5: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • 34d97ab: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE
  • 63e52ed: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
  • ad2e114: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • d69a097: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • 8084244: 8316319: Generational ZGC: The SoftMaxHeapSize might be wrong when CDS decreases the MaxHeapSize
  • ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/ada400cffe35140d62452e3899e5a04a40b737c8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 25, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

Going to push as commit e2cabfe.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 2adc2b4: 8317535: Shenandoah: Remove unused code
  • 711ab38: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold
  • cc189ff: 8295343: sun/security/pkcs11 tests fail on Linux RHEL 8.6 and newer
  • e87638c: 8321122: Shenandoah: Remove ShenandoahLoopOptsAfterExpansion flag
  • 90d7b17: 8321120: Shenandoah: Remove ShenandoahElasticTLAB flag
  • 7fcfea5: 8324050: Issue store-store barrier after re-materializing objects during deoptimization
  • 34d97ab: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE
  • 63e52ed: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1
  • ad2e114: 8323243: JNI invocation of an abstract instance method corrupts the stack
  • d69a097: 8322282: Incorrect LoaderConstraintTable::add_entry after JDK-8298468
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/ada400cffe35140d62452e3899e5a04a40b737c8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 26, 2024
@openjdk openjdk bot closed this Jan 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@luchenlin Pushed as commit e2cabfe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant