8324050: Issue store-store barrier after re-materializing objects during deoptimization

[shipilev]

Clean backport to improve deopt reliability. Adds the barrier on uncommonly used path. The functional and performance risk is low.

---

Progress

• JDK-8324050 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324050: Issue store-store barrier after re-materializing objects during deoptimization (Bug - P3 - Approved)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/211/head:pull/211
$ git checkout pull/211

Update a local copy of the PR:
$ git checkout pull/211
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 211

View PR using the GUI difftool:
$ git pr show -t 211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/211.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (70aed7f2)

[shipilev]

/approval request Clean backport to improve deopt reliability. Adds the barrier on uncommonly used path. The functional and performance risk is low.

[openjdk]

@shipilev
8324050: The approval request has been created successfully.

[vnkozlov]

Good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324050: Issue store-store barrier after re-materializing objects during deoptimization

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 34d97ab: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE
• 63e52ed: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit 7fcfea5.
Since your change was applied there have been 2 commits pushed to the master branch:

• 34d97ab: 8321269: Require platforms to define DEFAULT_CACHE_LINE_SIZE
• 63e52ed: 8318468: compiler/tiered/LevelTransitionTest.java fails with -XX:CompileThreshold=100 -XX:TieredStopAtLevel=1

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 7fcfea5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.