Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jan 24, 2024


Progress

  • JDK-8323640 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/213/head:pull/213
$ git checkout pull/213

Update a local copy of the PR:
$ git checkout pull/213
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/213/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 213

View PR using the GUI difftool:
$ git pr show -t 213

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/213.diff

Webrev

Link to Webrev Comment

Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back sendaoYan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 791b427f4410057cdcdf8fd8ea0dcce71f7dc513 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2024

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Feb 6, 2024

@sendaoYan You probably want to apply for approval using the /approval skara command.

@sendaoYan
Copy link
Member Author

This PR only change the testcase, the testcase change has been verified. Please review this PR.

@sendaoYan
Copy link
Member Author

/approval

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan usage: /approval [<id>] (request|cancel) [<text>]

@sendaoYan
Copy link
Member Author

/approval JDK-8325368 request

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan This issue is not associated with this pull request.

@sendaoYan
Copy link
Member Author

/approval JDK-8323640 request

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
JDK-8323640: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Feb 21, 2024
@jerboaa
Copy link
Contributor

jerboaa commented Feb 21, 2024

/approval JDK-8323640 request

@sendaoYan The approval request needs to come with a comment explaining the issue, why it's needed to be fixed a risk assessment if it's approved and so on. Please use that next time! See:
https://openjdk.org/projects/jdk-updates/approval.html

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
  • 93be33c: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 70112e3: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
  • e181516: 8315602: Open source swing security manager test
  • 70fa49e: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • ... and 51 more: https://git.openjdk.org/jdk21u-dev/compare/ad2e11417494cef94cbaa4cebca507aa03c47992...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 21, 2024
@sendaoYan
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@sendaoYan
Your change (at version a3a5931) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Feb 21, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 21, 2024

Going to push as commit 92d533e.
Since your change was applied there have been 61 commits pushed to the master branch:

  • 36569de: 8314629: Generational ZGC: Clearing All SoftReferences log line lacks GCId
  • 90c9f70: 8314164: java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java fails intermittently in timeout
  • 4fcc5c7: 8322790: RISC-V: Tune costs for shuffles with no conversion
  • a9792a8: 8324874: AArch64: crypto pmull based CRC32/CRC32C intrinsics clobber V8-V15 registers
  • d6f4f5e: 8318737: Fallback linker passes bad JNI handle
  • 4d4c47d: 8320890: [AIX] Find a better way to mimic dl handle equality
  • 93be33c: 8325672: C2: allocate PhaseIdealLoop::_loop_or_ctrl from C->comp_arena()
  • 70112e3: 8315891: java/foreign/TestLinker.java failed with "error occurred while instantiating class TestLinker: null"
  • e181516: 8315602: Open source swing security manager test
  • 70fa49e: 8324347: Enable "maybe-uninitialized" warning for FreeType 2.13.1
  • ... and 51 more: https://git.openjdk.org/jdk21u-dev/compare/ad2e11417494cef94cbaa4cebca507aa03c47992...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 21, 2024
@openjdk openjdk bot closed this Feb 21, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 21, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 21, 2024
@openjdk
Copy link

openjdk bot commented Feb 21, 2024

@jerboaa @sendaoYan Pushed as commit 92d533e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

/sponsor

@jerboaa Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants