Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 24, 2024

I backport this for parity with 21.0.3-oracle.

Resolved due to context. Will mark clean but probably recognized as such anyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313507 needs maintainer approval

Issue

  • JDK-8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList (Task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/215.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8471f6bbe692a0d1e293f9e09aaa4f32312eb6a 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jan 24, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 24, 2024

/clean

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Jan 24, 2024
@openjdk
Copy link

openjdk bot commented Jan 24, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 24, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 14f62ac: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 7f40804: 8324659: GHA: Generic jtreg errors are not reported
  • ca85d55: 8315761: Open source few swing JList and JMenuBar tests
  • a9498e5: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • bf7c218: 8321480: ISO 4217 Amendment 176 Update
  • e2cabfe: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • 2adc2b4: 8317535: Shenandoah: Remove unused code
  • 711ab38: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 29, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit 5df2a5c.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 45b428f: 8315600: Open source few more headless Swing misc tests
  • dead333: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • 14f62ac: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 7f40804: 8324659: GHA: Generic jtreg errors are not reported
  • ca85d55: 8315761: Open source few swing JList and JMenuBar tests
  • a9498e5: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • bf7c218: 8321480: ISO 4217 Amendment 176 Update
  • e2cabfe: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • 2adc2b4: 8317535: Shenandoah: Remove unused code
  • 711ab38: 8322255: Generational ZGC: ZPageSizeMedium should be set before MaxTenuringThreshold

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@GoeLin Pushed as commit 5df2a5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8313507 branch January 30, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant