Skip to content

8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 25, 2024

I backport this for parity with 21.0.3-oracle.

Not problemlisted in 21, omitted the corresponding patch. Will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320943 needs maintainer approval

Issue

  • JDK-8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/216/head:pull/216
$ git checkout pull/216

Update a local copy of the PR:
$ git checkout pull/216
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 216

View PR using the GUI difftool:
$ git pr show -t 216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/216.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 87516e29dc5015c4cab2c07c5539ad30f2768667 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 26, 2024

/clean

@openjdk openjdk bot added the clean label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 14f62ac: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 7f40804: 8324659: GHA: Generic jtreg errors are not reported
  • ca85d55: 8315761: Open source few swing JList and JMenuBar tests
  • a9498e5: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • bf7c218: 8321480: ISO 4217 Amendment 176 Update
  • e2cabfe: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • 2adc2b4: 8317535: Shenandoah: Remove unused code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Jan 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

Going to push as commit 9bc6bd6.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 5df2a5c: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
  • 45b428f: 8315600: Open source few more headless Swing misc tests
  • dead333: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
  • 14f62ac: 8324280: RISC-V: Incorrect implementation in VM_Version::parse_satp_mode
  • 7f40804: 8324659: GHA: Generic jtreg errors are not reported
  • ca85d55: 8315761: Open source few swing JList and JMenuBar tests
  • a9498e5: 8322142: JFR: Periodic tasks aren't orphaned between recordings
  • bf7c218: 8321480: ISO 4217 Amendment 176 Update
  • e2cabfe: 8316947: Write a test to check textArea triggers MouseEntered/MouseExited events properly
  • 2adc2b4: 8317535: Shenandoah: Remove unused code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2024
@openjdk openjdk bot closed this Jan 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

@GoeLin Pushed as commit 9bc6bd6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8320943 branch January 30, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant