Skip to content

8338428: Add logging of final VM flags while setting properties#2164

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8338428
Closed

8338428: Add logging of final VM flags while setting properties#2164
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
GoeLin:goetz_backport_8338428

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 9, 2025

Resolved copyrght, probably clean.


Progress

  • JDK-8338428 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338428: Add logging of final VM flags while setting properties (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2164/head:pull/2164
$ git checkout pull/2164

Update a local copy of the PR:
$ git checkout pull/2164
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2164

View PR using the GUI difftool:
$ git pr show -t 2164

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2164.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338428: Add logging of final VM flags while setting properties

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport bbd880775f73ac11dc2c86ec5b598bdb4305e699 8338428: Add logging of final VM flags while setting properties Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 9, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 9, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2025

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 10, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Sep 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

Going to push as commit 4827701.
Since your change was applied there have been 13 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2025
@openjdk openjdk bot closed this Sep 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@GoeLin Pushed as commit 4827701.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8338428 branch September 11, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant