-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint #217
8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint #217
Conversation
…only once per safepoint Reviewed-by: kdnilsen, ysr
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Not quite a clean backport, but conflicts were easily resolved. This change reduces work on the safepoint. We've tested this with Dacapo, Extremem, Heapothesys, SpecJBB2015 and SpecJVM2008. |
@earthling-amzn |
@earthling-amzn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 129 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@GoeLin Only the author (@earthling-amzn) is allowed to issue the |
/integrate |
@earthling-amzn |
/sponsor |
Going to push as commit ad5a087.
Your commit was automatically rebased without conflicts. |
@shipilev @earthling-amzn Pushed as commit ad5a087. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Trivial merge conflicts
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/217/head:pull/217
$ git checkout pull/217
Update a local copy of the PR:
$ git checkout pull/217
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/217/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 217
View PR using the GUI difftool:
$ git pr show -t 217
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/217.diff
Webrev
Link to Webrev Comment