Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint #217

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jan 25, 2024

Trivial merge conflicts


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321815 needs maintainer approval

Issue

  • JDK-8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/217/head:pull/217
$ git checkout pull/217

Update a local copy of the PR:
$ git checkout pull/217
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/217/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 217

View PR using the GUI difftool:
$ git pr show -t 217

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/217.diff

Webrev

Link to Webrev Comment

…only once per safepoint

Reviewed-by: kdnilsen, ysr
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 808a03927c153581cbece93a4f5a4f8242b61ef5 8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint Jan 25, 2024
@openjdk
Copy link

openjdk bot commented Jan 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@earthling-amzn
Copy link
Author

/approval request Not quite a clean backport, but conflicts were easily resolved. This change reduces work on the safepoint. We've tested this with Dacapo, Extremem, Heapothesys, SpecJBB2015 and SpecJVM2008.

@openjdk
Copy link

openjdk bot commented Jan 26, 2024

@earthling-amzn
8321815: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Feb 6, 2024

@earthling-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321815: Shenandoah: gc state should be synchronized to java threads only once per safepoint

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 129 new commits pushed to the master branch:

  • 608c98d: 8326496: [test] checkHsErrFileContent support printing hserr in error case
  • d42da09: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
  • 2a6688f: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • da02da7: 8325432: enhance assert message "relocation addr must be in this section"
  • c80be84: 8320005: Allow loading of shared objects with .a extension on AIX
  • 44fdfc7: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • c8e9f1d: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 7f5afa1: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 7505194: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 779204c: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • ... and 119 more: https://git.openjdk.org/jdk21u-dev/compare/2adc2b4f8a650ec8e8f01b57286a664eaf5975ec...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 6, 2024
@GoeLin
Copy link
Member

GoeLin commented Mar 7, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Mar 7, 2024

@GoeLin Only the author (@earthling-amzn) is allowed to issue the integrate command.

@earthling-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@earthling-amzn
Your change (at version 0bdfcb9) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

Going to push as commit ad5a087.
Since your change was applied there have been 129 commits pushed to the master branch:

  • 608c98d: 8326496: [test] checkHsErrFileContent support printing hserr in error case
  • d42da09: 8325743: test/jdk/java/nio/channels/unixdomain/SocketOptions.java enhance user name output in error case
  • 2a6688f: 8320129: "top" command during jtreg failure handler does not display CPU usage on OSX
  • da02da7: 8325432: enhance assert message "relocation addr must be in this section"
  • c80be84: 8320005: Allow loading of shared objects with .a extension on AIX
  • 44fdfc7: 8326101: [PPC64] Need to bailout cleanly if creation of stubs fails when code cache is out of space
  • c8e9f1d: 8320113: [macos14] : ShapeNotSetSometimes.java fails intermittently on macOS 14
  • 7f5afa1: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries
  • 7505194: 8320342: Use PassFailJFrame for TruncatedPopupMenuTest.java
  • 779204c: 8320570: NegativeArraySizeException decoding >1G UTF8 bytes with non-ascii characters
  • ... and 119 more: https://git.openjdk.org/jdk21u-dev/compare/2adc2b4f8a650ec8e8f01b57286a664eaf5975ec...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 13, 2024
@openjdk openjdk bot closed this Mar 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 13, 2024
@openjdk
Copy link

openjdk bot commented Mar 13, 2024

@shipilev @earthling-amzn Pushed as commit ad5a087.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants