Skip to content

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main#2184

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-fb8f2a0a-master
Closed

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main#2184
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-fb8f2a0a-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 11, 2025

I backport this for parity with 21.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8328562 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2184/head:pull/2184
$ git checkout pull/2184

Update a local copy of the PR:
$ git checkout pull/2184
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2184/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2184

View PR using the GUI difftool:
$ git pr show -t 2184

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2184.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 11, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 11, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport fb8f2a0a929ebe7f65c69741712b89bbb403ade9 8328562: Convert java/awt/InputMethods/DiacriticsTest/DiacriticsTest.java applet test to main Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 11, 2025
@openjdk
Copy link

openjdk bot commented Sep 11, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 11, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 11, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Sep 13, 2025

GHA failure: RiscV compile issue, unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 13, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2025

Going to push as commit 192abe9.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2025
@openjdk openjdk bot closed this Sep 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2025
@openjdk
Copy link

openjdk bot commented Sep 13, 2025

@GoeLin Pushed as commit 192abe9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant