Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Sep 12, 2025

Backporting JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems. Trivial fix to require test only run on 64 bit systems. Ran GHA Sanity Checks and adjusted tests directly on both 64 and 32 bit systems (automatically skipped on the latter). Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367372 needs maintainer approval

Issue

  • JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2203/head:pull/2203
$ git checkout pull/2203

Update a local copy of the PR:
$ git checkout pull/2203
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2203

View PR using the GUI difftool:
$ git pr show -t 2203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2203.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367372: Test `test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java` fails on 32 bit systems

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0f535aeb0ae2f7015300889a0ee9efbf10a15896 8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 12, 2025
@openjdk
Copy link

openjdk bot commented Sep 12, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems

Motivation: Without this change, the test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java test will continue to run and fail on 32-bit systems when using common build targets. With this change, the mentioned test will be skipped on 32 bit systems.

Risk: Low. Ran GHA Sanity Checks, and adjusted tests directly on both 64 and 32 bit systems (skipped automatically on latter). Patch is clean. Although change has only recently been addressed in tip, patch is a trivial one line change. Patch only adjusts a single test's code.

@openjdk
Copy link

openjdk bot commented Sep 12, 2025

@satyenme
8367372: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 12, 2025
@satyenme
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

Going to push as commit 4fdcf0e.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2025
@openjdk openjdk bot closed this Sep 15, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@satyenme Pushed as commit 4fdcf0e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant