-
Notifications
You must be signed in to change notification settings - Fork 148
8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems
#2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems Motivation: Without this change, the Risk: Low. Ran GHA Sanity Checks, and adjusted tests directly on both 64 and 32 bit systems (skipped automatically on latter). Patch is clean. Although change has only recently been addressed in tip, patch is a trivial one line change. Patch only adjusts a single test's code. |
|
/integrate |
|
Going to push as commit 4fdcf0e.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8367372: Test test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.java fails on 32 bit systems. Trivial fix to require test only run on 64 bit systems. Ran GHA Sanity Checks and adjusted tests directly on both 64 and 32 bit systems (automatically skipped on the latter). Patch is clean.
Progress
Issue
test/hotspot/jtreg/gc/TestObjectAlignmentCardSize.javafails on 32 bit systems (Bug - P4 - Approved)Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2203/head:pull/2203$ git checkout pull/2203Update a local copy of the PR:
$ git checkout pull/2203$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2203/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2203View PR using the GUI difftool:
$ git pr show -t 2203Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2203.diff
Using Webrev
Link to Webrev Comment