-
Notifications
You must be signed in to change notification settings - Fork 148
8365098: make/RunTests.gmk generates a wrong path to test artifacts on Alpine #2237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…n Alpine Reviewed-by: erikj, ihse
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
@wkia This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request I'd like to backport this to jdk21u-dev, as jdk21 tests have the same issue on Alpine - generate a wrong path to test artifacts. Clean backport. Build system fix in test artifacts path processing. Tier1 passes. |
|
/integrate |
|
/sponsor |
|
Going to push as commit b683857.
Your commit was automatically rebased without conflicts. |
This is backport of "JDK-8365098 make/RunTests.gmk generates a wrong path to test artifacts on Alpine" as JDK21 tests have the same issue on Alpine - generate a wrong path to test artifacts.
Clean backport. Build system fix, test artifacts path processing.
Tier1 passes.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2237/head:pull/2237$ git checkout pull/2237Update a local copy of the PR:
$ git checkout pull/2237$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2237/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2237View PR using the GUI difftool:
$ git pr show -t 2237Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2237.diff
Using Webrev
Link to Webrev Comment