Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313394: Array Elements in OldObjectSample event has the incorrect description #225

Closed
wants to merge 1 commit into from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Jan 30, 2024

Hi all,

I want to backport JDK-8313394 for jdk21u.
This is clean backport.

Would you review and sponsor this fix, please?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313394 needs maintainer approval

Issue

  • JDK-8313394: Array Elements in OldObjectSample event has the incorrect description (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/225.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8c325dea39f959ab6bb310c3913b98655e95734 8313394: Array Elements in OldObjectSample event has the incorrect description Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2024

@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@tkiriyama
Copy link
Contributor Author

/approval request It fixes only the description attribute of JFR event and the risk is low. All JFR tests are passed.

@openjdk
Copy link

openjdk bot commented Feb 28, 2024

@tkiriyama
8313394: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 28, 2024
@openjdk
Copy link

openjdk bot commented Feb 29, 2024

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313394: Array Elements in OldObjectSample event has the incorrect description

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 209 new commits pushed to the master branch:

  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • dc8759c: 8316053: Open some swing tests 3
  • ef13a82: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
  • 64b70be: 8326773: Bump update version for OpenJDK: jdk-21.0.4
  • ... and 199 more: https://git.openjdk.org/jdk21u-dev/compare/58b1b0cc359b5c14895c07560166779ec70975c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 29, 2024
@tkiriyama
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@tkiriyama
Your change (at version 75aa3c9) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 1, 2024

Going to push as commit 94634c0.
Since your change was applied there have been 210 commits pushed to the master branch:

  • 4243aed: 8324824: AArch64: Detect Ampere-1B core and update default options for Ampere CPUs
  • e667521: 8324123: aarch64: fix prfm literal encoding in assembler
  • 76ebcc1: 8322846: Running with -Djdk.tracePinnedThreads set can hang
  • 2d791b8: 8323170: j2dbench is using outdated javac source/target to be able to build by itself
  • 3eb5517: 8315373: Change VirtualThread to unmount after freezing, re-mount before thawing
  • cea29fe: 8325213: Flags introduced by configure script are not passed to ADLC build
  • 677556d: 8320275: assert(_chunk->bitmap().at(index)) failed: Bit not set at index
  • 8ac4313: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16
  • dc8759c: 8316053: Open some swing tests 3
  • ef13a82: 8324817: Parallel GC does not pre-touch all heap pages when AlwaysPreTouch enabled and large page disabled
  • ... and 200 more: https://git.openjdk.org/jdk21u-dev/compare/58b1b0cc359b5c14895c07560166779ec70975c9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 1, 2024
@openjdk openjdk bot closed this Mar 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 1, 2024
@openjdk
Copy link

openjdk bot commented Mar 1, 2024

@phohensee @tkiriyama Pushed as commit 94634c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants