-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313394: Array Elements in OldObjectSample event has the incorrect description #225
Conversation
👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/approval request It fixes only the description attribute of JFR event and the risk is low. All JFR tests are passed. |
@tkiriyama |
@tkiriyama This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 209 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@tkiriyama |
/sponsor |
Going to push as commit 94634c0.
Your commit was automatically rebased without conflicts. |
@phohensee @tkiriyama Pushed as commit 94634c0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
I want to backport JDK-8313394 for jdk21u.
This is clean backport.
Would you review and sponsor this fix, please?
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/225/head:pull/225
$ git checkout pull/225
Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/225/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 225
View PR using the GUI difftool:
$ git pr show -t 225
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/225.diff
Webrev
Link to Webrev Comment