Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests #226

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2024

I backport this for parity with 21.0.4-oracle.

I had to resolve VectorizationTestRunner.java because "8311691: C2: Remove legacy code related to PostLoopMultiversioning" is not in 21.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8309697 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/226.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a03954e6c57369446ef77136966662780e4b1c4e 8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests Jan 30, 2024
@openjdk
Copy link

openjdk bot commented Jan 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 30, 2024
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jan 30, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Jan 31, 2024
@openjdk
Copy link

openjdk bot commented Feb 3, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309697: [TESTBUG] Remove "@requires vm.flagless" from jtreg vectorization tests

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • c6ebfdf: 8320052: Zero: Use __atomic built-ins for atomic RMW operations
  • ffab458: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • 869df3b: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
  • 0466741: 8315611: Open source swing text/html and tree test
  • c971925: 8318157: RISC-V: implement ensureMaterializedForStackWalk intrinsic
  • 2518d20: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
  • 9bc6bd6: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
  • 5df2a5c: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
  • 45b428f: 8315600: Open source few more headless Swing misc tests
  • dead333: 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 3, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Feb 5, 2024

/integrate

@GoeLin
Copy link
Member Author

GoeLin commented Feb 5, 2024

Thanks for the review!

@openjdk
Copy link

openjdk bot commented Feb 5, 2024

Going to push as commit e75ca5a.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 38c5df1: 8323637: Capture hotspot replay files in GHA
  • 0b79e90: 8324937: GHA: Avoid multiple test suites per job
  • c6ebfdf: 8320052: Zero: Use __atomic built-ins for atomic RMW operations
  • ffab458: 8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case
  • 869df3b: 8323101: C2: assert(n->in(0) == nullptr) failed: divisions with zero check should already have bailed out earlier in split-if
  • 0466741: 8315611: Open source swing text/html and tree test
  • c971925: 8318157: RISC-V: implement ensureMaterializedForStackWalk intrinsic
  • 2518d20: 8323154: C2: assert(cmp != nullptr && cmp->Opcode() == Op_Cmp(bt)) failed: no exit test
  • 9bc6bd6: 8320943: Files/probeContentType/Basic.java fails on latest Windows 11 - content type mismatch
  • 5df2a5c: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
  • ... and 2 more: https://git.openjdk.org/jdk21u-dev/compare/14f62ace5fe0d83f8dcb05199e75c1b533957c9f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 5, 2024
@openjdk openjdk bot closed this Feb 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 5, 2024
@openjdk
Copy link

openjdk bot commented Feb 5, 2024

@GoeLin Pushed as commit e75ca5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants