-
Notifications
You must be signed in to change notification settings - Fork 147
8328247: Remove redundant dir for tests converted from applet to main #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
/issue 8355333 |
|
@satyenme |
|
|
|
/approval request for backport of JDK-8328247: Remove redundant dir for tests converted from applet to main (and most of 8355333: Some Problem list entries point to non-existent / wrong files) Motivation: With this change, we clean up the test structure and exclude list without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and renamed manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle. |
|
Hi @satyenme I think the fact to have clean backports and a 1:1 matching to what happened in head |
|
Sure, that makes sense - I can take a look at doing that |
|
/issue 8353958 |
|
@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@satyenme |
|
Hi @satyenme, my ask was not to include that change here, but to do three different backports in the right order. Thanks. |
|
Got it, sorry for misunderstanding. Was initially hesitant to do that since both 8353958 and 8328247 will cause non-excluded (but expected) test failures without 8355333. I suppose if I integrate them at the same time though it shouldn't be an issue. |
|
New PRs:
|
Backporting JDK-8328247: Remove redundant dir for tests converted from applet to main. Renames three javax swing tests, as per change accepted by Oracle.
Notably, this change also adapts JDK-8355333: Some Problem list entries point to non-existent / wrong files, to ensure that the renamed files are correctly excluded. I'm also removing the PrintToFileTest tests from the exclude list (since these only run on windows anyway). The
ScrollPaneEventType.javatest hasn't been backported yet (I'll follow up with another PR doing so and excluding as needed), so I've left that change out.Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is clean. Backporting for parity with Oracle.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2260/head:pull/2260$ git checkout pull/2260Update a local copy of the PR:
$ git checkout pull/2260$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2260/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2260View PR using the GUI difftool:
$ git pr show -t 2260Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2260.diff
Using Webrev
Link to Webrev Comment