Skip to content

Conversation

@satyenme
Copy link

@satyenme satyenme commented Sep 22, 2025

Backporting JDK-8328247: Remove redundant dir for tests converted from applet to main. Renames three javax swing tests, as per change accepted by Oracle.

Notably, this change also adapts JDK-8355333: Some Problem list entries point to non-existent / wrong files, to ensure that the renamed files are correctly excluded. I'm also removing the PrintToFileTest tests from the exclude list (since these only run on windows anyway). The ScrollPaneEventType.java test hasn't been backported yet (I'll follow up with another PR doing so and excluding as needed), so I've left that change out.

Ran GHA Sanity Checks, local Tier 1 and 2, and new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8328247 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8355333 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8353958 needs maintainer approval

Issues

  • JDK-8328247: Remove redundant dir for tests converted from applet to main (Bug - P4 - Approved)
  • JDK-8355333: Some Problem list entries point to non-existent / wrong files (Bug - P4 - Requested)
  • JDK-8353958: Open source several AWT ScrollPane tests - Batch 2 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2260/head:pull/2260
$ git checkout pull/2260

Update a local copy of the PR:
$ git checkout pull/2260
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2260

View PR using the GUI difftool:
$ git pr show -t 2260

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2260.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ece4124f25f676da9bf2d1b7fd8e4394dd7d31af 8328247: Remove redundant dir for tests converted from applet to main Sep 22, 2025
@openjdk
Copy link

openjdk bot commented Sep 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 22, 2025
@satyenme
Copy link
Author

/issue 8355333

@openjdk
Copy link

openjdk bot commented Sep 22, 2025

@satyenme
Adding additional issue to issue list: 8355333: Some Problem list entries point to non-existent / wrong files.

@mlbridge
Copy link

mlbridge bot commented Sep 22, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

/approval request for backport of JDK-8328247: Remove redundant dir for tests converted from applet to main (and most of 8355333: Some Problem list entries point to non-existent / wrong files)

Motivation: With this change, we clean up the test structure and exclude list without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2 and renamed manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle.

@openjdk
Copy link

openjdk bot commented Sep 24, 2025

@satyenme
8328247: The approval request has been created successfully.
8355333: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 24, 2025
@GoeLin
Copy link
Member

GoeLin commented Sep 25, 2025

Hi @satyenme
would it be possible to first backport
8353958: Open source several AWT ScrollPane tests - Batch 2
then
8328247: Remove redundant dir for tests converted from applet to main
and last
DK-8355333: Some Problem list entries point to non-existent / wrong files

I think the fact to have clean backports and a 1:1 matching to what happened in head
is more helpful than avoiding a short time (until 8355333 is pushed) in which the tests
are not problem properly listed.

@satyenme
Copy link
Author

satyenme commented Sep 26, 2025

Sure, that makes sense - I can take a look at doing that

@satyenme
Copy link
Author

/issue 8353958

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@satyenme Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk
Copy link

openjdk bot commented Sep 26, 2025

@satyenme
Adding additional issue to issue list: 8353958: Open source several AWT ScrollPane tests - Batch 2.

@GoeLin
Copy link
Member

GoeLin commented Sep 29, 2025

Hi @satyenme, my ask was not to include that change here, but to do three different backports in the right order. Thanks.

@satyenme
Copy link
Author

Got it, sorry for misunderstanding. Was initially hesitant to do that since both 8353958 and 8328247 will cause non-excluded (but expected) test failures without 8355333. I suppose if I integrate them at the same time though it shouldn't be an issue.

@satyenme
Copy link
Author

satyenme commented Sep 29, 2025

@satyenme satyenme closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants